Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: sync/internal_api/base_node.cc

Issue 11413153: Remove legacy GetURL(),SetURL(),GetFaviconBytes(),SetFaviconBytes() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/base_node.cc
diff --git a/sync/internal_api/base_node.cc b/sync/internal_api/base_node.cc
index f5c6c170c838bec52526ac4903b3c0fd6ca3e6f0..990a986c394f31a8af1549c49902629215de455f 100644
--- a/sync/internal_api/base_node.cc
+++ b/sync/internal_api/base_node.cc
@@ -205,10 +205,6 @@ std::string BaseNode::GetTitle() const {
return result;
}
-GURL BaseNode::GetURL() const {
- return GURL(GetBookmarkSpecifics().url());
-}
-
bool BaseNode::HasChildren() const {
syncable::Directory* dir = GetTransaction()->GetDirectory();
syncable::BaseTransaction* trans = GetTransaction()->GetWrappedTrans();
@@ -299,15 +295,6 @@ DictionaryValue* BaseNode::GetDetailsAsValue() const {
return node_info;
}
-void BaseNode::GetFaviconBytes(std::vector<unsigned char>* output) const {
- if (!output)
- return;
- const std::string& favicon = GetBookmarkSpecifics().favicon();
- output->assign(reinterpret_cast<const unsigned char*>(favicon.data()),
- reinterpret_cast<const unsigned char*>(favicon.data() +
- favicon.length()));
-}
-
int64 BaseNode::GetExternalId() const {
return GetEntry()->Get(syncable::LOCAL_EXTERNAL_ID);
}

Powered by Google App Engine
This is Rietveld 408576698