Remove legacy GetURL(),SetURL(),GetFaviconBytes(),SetFaviconBytes()

chrome/browser/sync/glue/bookmark_change_processor.h

Index: chrome/browser/sync/glue/bookmark_change_processor.h
diff --git a/chrome/browser/sync/glue/bookmark_change_processor.h b/chrome/browser/sync/glue/bookmark_change_processor.h
index 7adc252250686bdd3914d1204fe151735dea3983..2eb851aa6a2122af2b3050eed6f569c18f2a4c55 100644
--- a/chrome/browser/sync/glue/bookmark_change_processor.h
+++ b/chrome/browser/sync/glue/bookmark_change_processor.h
@@ -14,6 +14,10 @@
 #include "chrome/browser/sync/glue/data_type_error_handler.h"
 #include "chrome/browser/sync/glue/sync_backend_host.h"
 
+namespace base {
+class RefCountedMemory;
+}
+
 namespace syncer {
 class WriteNode;
 class WriteTransaction;
@@ -89,13 +93,13 @@ class BookmarkChangeProcessor : public BookmarkModelObserver,
                                  const BookmarkNode* bookmark_node,
                                  BookmarkModel* model);
 
-  // Applies the favicon data in |icon_bytes_vector| to |bookmark_node|.
+  // Applies the favicon 1x |bitmap_data| to |bookmark_node|.
   // |profile| is the profile that contains the HistoryService and BookmarkModel
   // for the bookmark in question.
   static void ApplyBookmarkFavicon(
       const BookmarkNode* bookmark_node,
       Profile* profile,
-      const std::vector<unsigned char>& icon_bytes_vector);
+      scoped_refptr<base::RefCountedMemory> bitmap_data);

[Nicolas Zea, 2012/11/26 22:15:45]

const ref? (to avoid adding temporary references)

 
   // Sets the favicon of the given sync node from the given bookmark node.
   static void SetSyncNodeFavicon(const BookmarkNode* bookmark_node,