Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Issue 11413061: Fix Android build. (Closed)

Created:
8 years, 1 month ago by wjia(left Chromium)
Modified:
8 years, 1 month ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Visibility:
Public.

Description

Fix Android build. On Android, in default include directory (e.g., android_tools/ndk/platforms/android-9/arch-arm/usr/include), same filename exists in both include/ and include/machine. In some cases, the compiler picked up the wrong header file. Change it to use only include/ as default. BUG=161417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168576

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review, use CHROMIUM_BUILD flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M libvpx.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M source/libvpx/vpx_ports/arm_cpudetect.c View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wjia(left Chromium)
8 years, 1 month ago (2012-11-19 06:15:22 UTC) #1
Alpha Left Google
http://codereview.chromium.org/11413061/diff/1/source/libvpx/vpx_ports/arm_cpudetect.c File source/libvpx/vpx_ports/arm_cpudetect.c (right): http://codereview.chromium.org/11413061/diff/1/source/libvpx/vpx_ports/arm_cpudetect.c#newcode104 source/libvpx/vpx_ports/arm_cpudetect.c:104: #include <machine/cpu-features.h> It's better that we upstream this change ...
8 years, 1 month ago (2012-11-19 18:46:33 UTC) #2
wjia(left Chromium)
PTAL. http://codereview.chromium.org/11413061/diff/1/source/libvpx/vpx_ports/arm_cpudetect.c File source/libvpx/vpx_ports/arm_cpudetect.c (right): http://codereview.chromium.org/11413061/diff/1/source/libvpx/vpx_ports/arm_cpudetect.c#newcode104 source/libvpx/vpx_ports/arm_cpudetect.c:104: #include <machine/cpu-features.h> On 2012/11/19 18:46:33, Alpha wrote: > ...
8 years, 1 month ago (2012-11-19 19:41:48 UTC) #3
Alpha Left Google
8 years, 1 month ago (2012-11-19 19:42:18 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698