Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: sdk/lib/html/scripts/systemnative.py

Issue 11413053: Remove _NodeListWrapper, make NodeList less special. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/scripts/systemnative.py
diff --git a/sdk/lib/html/scripts/systemnative.py b/sdk/lib/html/scripts/systemnative.py
index 667150046484fb598c97a0ed7058d824b14c46d5..ec40f594f55c59a29f284a56c1df8b17a57a6b73 100644
--- a/sdk/lib/html/scripts/systemnative.py
+++ b/sdk/lib/html/scripts/systemnative.py
@@ -392,20 +392,12 @@ class DartiumBackend(HtmlDartGenerator):
if self._HasNativeIndexSetter():
self._EmitNativeIndexSetter(dart_element_type)
else:
- # The HTML library implementation of NodeList has a custom indexed setter
- # implementation that uses the parent node the NodeList is associated
- # with if one is available.
- if self._interface.id != 'NodeList':
- self._members_emitter.Emit(
- '\n'
- ' void operator[]=(int index, $TYPE value) {\n'
- ' throw new UnsupportedError("Cannot assign element of immutable List.");\n'
- ' }\n',
- TYPE=dart_element_type)
-
- # The list interface for this class is manually generated.
- if self._interface.id == 'NodeList':
- return
+ self._members_emitter.Emit(
+ '\n'
+ ' void operator[]=(int index, $TYPE value) {\n'
+ ' throw new UnsupportedError("Cannot assign element of immutable List.");\n'
+ ' }\n',
+ TYPE=dart_element_type)
# TODO(sra): Use separate mixins for mutable implementations of List<T>.
# TODO(sra): Use separate mixins for typed array implementations of List<T>.

Powered by Google App Engine
This is Rietveld 408576698