Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: sdk/lib/html/scripts/generator.py

Issue 11413053: Remove _NodeListWrapper, make NodeList less special. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/scripts/generator.py
diff --git a/sdk/lib/html/scripts/generator.py b/sdk/lib/html/scripts/generator.py
index 1b4a1842996e0da68cb88162a6860252840fe306..57ac4510eb266a9af89503efde75a96faad474dd 100644
--- a/sdk/lib/html/scripts/generator.py
+++ b/sdk/lib/html/scripts/generator.py
@@ -705,17 +705,11 @@ class InterfaceIDLTypeInfo(IDLTypeInfo):
self._type_registry = type_registry
def dart_type(self):
- # TODO(podivilov): why NodeList is special?
Emily Fortuna 2012/11/17 02:44:30 woohoo!
- if self.idl_type() == 'NodeList':
- return 'List<Node>'
if self.list_item_type() and not self.has_generated_interface():
return 'List<%s>' % self._type_registry.TypeInfo(self._data.item_type).dart_type()
return self._data.dart_type or self._dart_interface_name
def narrow_dart_type(self):
- # TODO(podivilov): why NodeList is special?
- if self.idl_type() == 'NodeList':
- return 'List<Node>'
if self.list_item_type():
return self.idl_type()
# TODO(podivilov): only primitive and collection types should override
@@ -727,8 +721,6 @@ class InterfaceIDLTypeInfo(IDLTypeInfo):
return self.interface_name()
def interface_name(self):
- if self.list_item_type() and not self.has_generated_interface():
- return self.dart_type()
return self._dart_interface_name
def implementation_name(self):
@@ -1022,7 +1014,8 @@ _idl_type_registry = {
'MediaStreamList': TypeData(clazz='Interface',
item_type='MediaStream', suppress_interface=True),
'NamedNodeMap': TypeData(clazz='Interface', item_type='Node'),
- 'NodeList': TypeData(clazz='Interface', item_type='Node'),
+ 'NodeList': TypeData(clazz='Interface', item_type='Node',
+ suppress_interface=True),
'SVGAnimatedLengthList': TypeData(clazz='Interface',
item_type='SVGAnimatedLength'),
'SVGAnimatedNumberList': TypeData(clazz='Interface',

Powered by Google App Engine
This is Rietveld 408576698