alternate ntp: implement searchbox api for instant overlay to adopt themes

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 177e5394768e4689cf09d426c43b6265159aff36..57f755c3f4733a79561f8924015723b877f66ef5 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1852,12 +1852,21 @@ std::string BrowserView::GetClassName() const {
 void BrowserView::Layout() {
   if (ignore_layout_)
     return;
+
+  int prev_content_height = contents_container_->height();
+
   views::View::Layout();
 
   // The status bubble position requires that all other layout finish first.
   LayoutStatusBubble();
 
   MaybeStackBookmarkBarAtTop();
+
+  if (browser_->instant_controller() &&
+      prev_content_height != contents_container_->height()) {

[sky, 2012/11/19 15:07:31]

Why do you need to check pref_content_height? Can't you do this always?

[kuan, 2012/11/19 16:59:41]

if page is ntp and theme image is not top-aligned,
BrowserInstantController::SetContentHeight would send the event to the renderer
process, which would then dispatch it to the js callback.  since the value is
not dispatched everytime and the last dispatched value is not remembered, i
can't check if value has changed in SetContentHeight b4 dispatching it.  that
means i'll hv to check it here - won't dispatching the same value every time be
an overkill?

+    browser_->instant_controller()->SetContentHeight(
+        contents_container_->height());
+  }
 }
 
 void BrowserView::PaintChildren(gfx::Canvas* canvas) {