alternate ntp: implement searchbox api for instant overlay to adopt themes

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 1834 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserView, views::View overrides:
 
 std::string BrowserView::GetClassName() const {
   return kViewClassName;
 }
 
 void BrowserView::Layout() {
   if (ignore_layout_)
     return;
+
+  int prev_content_height = contents_container_->height();
+
   views::View::Layout();
 
   // The status bubble position requires that all other layout finish first.
   LayoutStatusBubble();
 
   MaybeStackBookmarkBarAtTop();
+
+  if (browser_->instant_controller() &&
+      prev_content_height != contents_container_->height()) {

[sky, 2012/11/19 15:07:31]

Why do you need to check pref_content_height? Can't you do this always?

[kuan, 2012/11/19 16:59:41]

if page is ntp and theme image is not top-aligned,
BrowserInstantController::SetContentHeight would send the event to the renderer
process, which would then dispatch it to the js callback.  since the value is
not dispatched everytime and the last dispatched value is not remembered, i
can't check if value has changed in SetContentHeight b4 dispatching it.  that
means i'll hv to check it here - won't dispatching the same value every time be
an overkill?

+    browser_->instant_controller()->SetContentHeight(
+        contents_container_->height());
+  }
 }
 
 void BrowserView::PaintChildren(gfx::Canvas* canvas) {
   // Paint the |infobar_container_| last so that it may paint its
   // overlapping tabs.
   for (int i = 0; i < child_count(); ++i) {
     View* child = child_at(i);
     if (child != infobar_container_)
       child->Paint(canvas);
   }
@@ skipping 717 matching lines @@
     modal_browser->window()->Activate();
   }
 
   AppModalDialogQueue::GetInstance()->ActivateModalDialog();
 }
 
 void BrowserView::MaybeStackBookmarkBarAtTop() {
   if (bookmark_bar_view_.get())
     bookmark_bar_view_->MaybeStackAtTop();
 }