content/browser/frame_host/render_frame_host_impl.cc - Issue 1141283002: Replicate whether a frame is in a document or shadow tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1141283002: Replicate whether a frame is in a document or shadow tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | content/renderer/render_frame_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 935a9cf3a16031b0946842d400212f0beab740f6..da74912a748c631ad91b15f0dcb32620eaf4820f 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -706,6 +706,7 @@ void RenderFrameHostImpl::OnAddMessageToConsole(

}

void RenderFrameHostImpl::OnCreateChildFrame(int new_routing_id,

+ blink::WebTreeScopeType scope,

const std::string& frame_name,

SandboxFlags sandbox_flags) {

// It is possible that while a new RenderFrameHost was committed, the

@@ -717,7 +718,7 @@ void RenderFrameHostImpl::OnCreateChildFrame(int new_routing_id,

RenderFrameHostImpl* new_frame =

frame_tree_->AddFrame(frame_tree_node_, GetProcess()->GetID(),

- new_routing_id, frame_name, sandbox_flags);

+ new_routing_id, scope, frame_name, sandbox_flags);

if (!new_frame)

return;