Chromium Code Reviews| Index: content/renderer/render_frame_proxy.cc |
| diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc |
| index eaaa2abeaa546e0a8f0d85b8c4a43527189ef735..fba66c0094cb49bedf05ced502c1313f93d4ed75 100644 |
| --- a/content/renderer/render_frame_proxy.cc |
| +++ b/content/renderer/render_frame_proxy.cc |
| @@ -39,7 +39,8 @@ base::LazyInstance<FrameMap> g_frame_map = LAZY_INSTANCE_INITIALIZER; |
| // static |
| RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame( |
| RenderFrameImpl* frame_to_replace, |
| - int routing_id) { |
| + int routing_id, |
| + blink::WebTreeScopeType scope) { |
| CHECK_NE(routing_id, MSG_ROUTING_NONE); |
| scoped_ptr<RenderFrameProxy> proxy( |
| @@ -48,7 +49,8 @@ RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame( |
| // When a RenderFrame is replaced by a RenderProxy, the WebRemoteFrame should |
| // always come from WebRemoteFrame::create and a call to WebFrame::swap must |
| // follow later. |
| - blink::WebRemoteFrame* web_frame = blink::WebRemoteFrame::create(proxy.get()); |
| + blink::WebRemoteFrame* web_frame = |
| + blink::WebRemoteFrame::create(scope, proxy.get()); |
| proxy->Init(web_frame, frame_to_replace->render_view()); |
| return proxy.release(); |
| } |
| @@ -65,7 +67,8 @@ RenderFrameProxy* RenderFrameProxy::CreateFrameProxy( |
| if (parent_routing_id == MSG_ROUTING_NONE) { |
| // Create a top level frame. |
| render_view = RenderViewImpl::FromRoutingID(render_view_routing_id); |
| - web_frame = blink::WebRemoteFrame::create(proxy.get()); |
| + web_frame = |
| + blink::WebRemoteFrame::create(replicated_state.scope, proxy.get()); |
| render_view->webview()->setMainFrame(web_frame); |
| } else { |
| // Create a frame under an existing parent. The parent is always expected |
| @@ -74,6 +77,7 @@ RenderFrameProxy* RenderFrameProxy::CreateFrameProxy( |
| RenderFrameProxy* parent = |
| RenderFrameProxy::FromRoutingID(parent_routing_id); |
| web_frame = parent->web_frame()->createRemoteChild( |
| + replicated_state.scope, |
| blink::WebString::fromUTF8(replicated_state.name), |
| RenderFrameImpl::ContentToWebSandboxFlags( |
| replicated_state.sandbox_flags), |
| @@ -85,6 +89,8 @@ RenderFrameProxy* RenderFrameProxy::CreateFrameProxy( |
| // Initialize proxy's WebRemoteFrame with the security origin and other |
| // replicated information. |
| + // TODO(dcheng): Shouldn't we only need to call when creating a top-level |
| + // frame proxy? |
|
Charlie Reis
2015/05/20 21:38:40
Daniel/Nasko: What's the outcome of your discussio
dcheng
2015/05/21 18:16:16
This is basically a TODO for future cleanup. This
Charlie Reis
2015/05/21 23:18:17
Acknowledged.
|
| proxy->SetReplicatedState(replicated_state); |
| return proxy.release(); |