Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5207)

Unified Diff: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

Issue 1141253003: chrome.platformKeys: Add filtering by certificate types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
diff --git a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
index a7ce5b5d6adb9f3489c19ea060efe419aa65dc6f..11123f6594fec649f5240fbbbe31e3846a438e21 100644
--- a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
+++ b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
@@ -765,7 +765,11 @@ void SelectClientCertificates(const ClientCertificateRequest& request,
scoped_refptr<net::SSLCertRequestInfo> cert_request_info(
new net::SSLCertRequestInfo);
- cert_request_info->cert_key_types = request.certificate_key_types;
+
+ // Currently we omit passing down the requested certificate type to the NSS
pneubeck (no reviews) 2015/05/19 10:09:00 s/NSS/net/
cschuet (SLOW) 2015/05/19 11:36:23 Done.
+ // layer, as NSS does not support filtering certificates by type. Rather we
pneubeck (no reviews) 2015/05/19 10:09:00 s/NSS/it/
cschuet (SLOW) 2015/05/19 11:36:23 Done.
+ // retrieve certificates of all types and perform the filtering in
+ // PlaformKeysService::GotMatchingCerts().
pneubeck (no reviews) 2015/05/19 10:09:00 ... of all type and the caller has to apply filter
cschuet (SLOW) 2015/05/19 11:36:23 Done.
cert_request_info->cert_authorities = request.certificate_authorities;
const user_manager::User* user =

Powered by Google App Engine
This is Rietveld 408576698