Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 11299292: Roll Skia DEPS to r6640 & remove supressions (Closed)

Created:
8 years ago by robertphillips
Modified:
8 years ago
Reviewers:
Stephen Chennney, reed1
CC:
chromium-reviews, skia-dev_google.com, hwennborg
Visibility:
Public.

Description

Roll Skia DEPS to r6640 & remove supressions control: https://codereview.chromium.org/11348340/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -77 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
robertphillips
It looks like we're having trouble with: linux: platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing.html [ ImageOnlyFailure ] windows: svg/carto.net/colourpicker.svg [ ...
8 years ago (2012-12-03 13:56:57 UTC) #1
Stephen Chennney
8 years ago (2012-12-03 14:56:43 UTC) #2
I am about to rebaseline color-picker and shadow-drawing in WebKit. They are
expected failures according to garden-o-matic and it appears they are simply
missed rebaselines from earlier.

So no suppressions required and this LGTM.

Powered by Google App Engine
This is Rietveld 408576698