Issue 11412294: NaCl: Stop disabling the sandbox on Linux for testing in nacl_integration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412294: NaCl: Stop disabling the sandbox on Linux for testing in nacl_integration (Closed)

Created:
8 years ago by Mark Seaborn

Modified:
8 years ago

Reviewers:
Nick Bray (chromium)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Stop disabling the sandbox on Linux for testing in nacl_integration These days, Linux Chromium uses two sandboxes simultaneously: a SUID sandbox and (on recent kernels) a seccomp-BPF sandbox. There's no reason to disable the seccomp-BPF sandbox when running NaCl tests. There's not much reason to disable the SUID sandbox either: the SUID helper should be installed on the bots these days, but if it's not present Chromium should continue fine without it. BUG=none TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170855

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages