Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

Issue 11412294: NaCl: Stop disabling the sandbox on Linux for testing in nacl_integration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py
diff --git a/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py b/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py
index 07780773a880f80e4ba359ad45c478269ccc744d..09bf76032928d1a54043bd04845b9a2c58eaf174 100755
--- a/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py
+++ b/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py
@@ -286,11 +286,6 @@ class ChromeLauncher(BrowserLauncher):
if self.options.ppapi_plugin is None:
cmd.append('--enable-nacl')
disable_sandbox = False
- # Sandboxing Chrome on Linux requires a SUIDed helper binary. This
- # binary may not be installed, so disable sandboxing to avoid the
- # corner cases where it may fail. This is a little scarry, because it
- # means we are not testing NaCl inside the outer sandbox on Linux.
- disable_sandbox |= PLATFORM == 'linux'
# Chrome process can't access file within sandbox
disable_sandbox |= self.options.nacl_exe_stdin is not None
disable_sandbox |= self.options.nacl_exe_stdout is not None
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698