Creating a skeleton for Google Now for Chrome implementation.

chrome/browser/chrome_browser_main.cc

Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index e93cc98b9bc7e07a81774b6ee4866a12d02dfcd7..bbcaf4934687fcaab23a25264821ee760e1908a6 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -84,6 +84,7 @@
 #include "chrome/browser/translate/translate_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/google_now/google_now_service_factory.h"
 #include "chrome/browser/ui/startup/default_browser_prompt.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/browser/ui/uma_browsing_activity_observer.h"
@@ -1406,6 +1407,14 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
   CloudPrintProxyServiceFactory::GetForProfile(profile_);
 #endif
 
+  // Create the instance of the Google Now service.

[rgustafson, 2012/12/03 19:28:59]

Just to clarify, this class (chrome_browser_main) does get created just once per
profile regardless of windows, etc etc? This isn't immediately obvious. Can you
point me to where you figured this out?

[rgustafson, 2012/12/03 19:38:03]

Commenting on my own comment... The singleton properties are brought by the
factory class, but I'm still wondering when this guy is created.

On 2012/12/03 19:28:59, rgustafson wrote:

[vadimt, 2012/12/03 20:48:57]

Done.

[vadimt, 2012/12/03 20:48:57]

That's an incredibly good question! You've actually found a bug!
This place is called only once, at the browser's startup. This is how the
factory and the first instance of the service is created.

Now, during (too aggressive) cleanup I've removed
GoogleNowServiceFactory::ServiceIsCreatedWithProfile method. Thanks to it,
additional instances of the service will be automatically created when the user
opens other profiles. I've re-added the method; thanks!

[rgustafson, 2012/12/04 00:38:01]

Okay good, just wanted to make sure the multi-profile case was covered. LGTM.
On 2012/12/03 20:48:57, vadimt wrote:

+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kEnableGoogleNowIntegration)) {
+    GoogleNowServiceFactory::GetForProfile(profile_);
+  }
+#endif
+
   // Start watching all browser threads for responsiveness.
   ThreadWatcherList::StartWatchingAll(parsed_command_line());