Creating a skeleton for Google Now for Chrome implementation.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 66 matching lines @@
 #include "chrome/browser/search_engines/search_engine_type.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_prepopulate_data.h"
 #include "chrome/browser/search_engines/template_url_service.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/service/service_process_control.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/translate/translate_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/google_now/google_now_service_factory.h"
 #include "chrome/browser/ui/startup/default_browser_prompt.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/browser/ui/uma_browsing_activity_observer.h"
 #include "chrome/browser/ui/user_data_dir_dialog.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager_backend.h"
 #include "chrome/common/child_process_logging.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_result_codes.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 1302 matching lines @@
 
   // Create the instance of the cloud print proxy service so that it can launch
   // the service process if needed. This is needed because the service process
   // might have shutdown because an update was available.
   // TODO(torne): this should maybe be done with
   // ProfileKeyedServiceFactory::ServiceIsCreatedWithProfile() instead?
 #if !defined(OS_ANDROID)
   CloudPrintProxyServiceFactory::GetForProfile(profile_);
 #endif
 
+  // Create the instance of the Google Now service.

[rgustafson, 2012/12/03 19:28:59]

Just to clarify, this class (chrome_browser_main) does get created just once per
profile regardless of windows, etc etc? This isn't immediately obvious. Can you
point me to where you figured this out?

[rgustafson, 2012/12/03 19:38:03]

Commenting on my own comment... The singleton properties are brought by the
factory class, but I'm still wondering when this guy is created.

On 2012/12/03 19:28:59, rgustafson wrote:

[vadimt, 2012/12/03 20:48:57]

Done.

[vadimt, 2012/12/03 20:48:57]

That's an incredibly good question! You've actually found a bug!
This place is called only once, at the browser's startup. This is how the
factory and the first instance of the service is created.

Now, during (too aggressive) cleanup I've removed
GoogleNowServiceFactory::ServiceIsCreatedWithProfile method. Thanks to it,
additional instances of the service will be automatically created when the user
opens other profiles. I've re-added the method; thanks!

[rgustafson, 2012/12/04 00:38:01]

Okay good, just wanted to make sure the multi-profile case was covered. LGTM.
On 2012/12/03 20:48:57, vadimt wrote:

+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kEnableGoogleNowIntegration)) {
+    GoogleNowServiceFactory::GetForProfile(profile_);
+  }
+#endif
+
   // Start watching all browser threads for responsiveness.
   ThreadWatcherList::StartWatchingAll(parsed_command_line());
 
 #if !defined(DISABLE_NACL)
   if (parsed_command_line().HasSwitch(switches::kPnaclDir)) {
     PathService::Override(chrome::DIR_PNACL_BASE,
                           parsed_command_line().GetSwitchValuePath(
                               switches::kPnaclDir));
   }
   NaClProcessHost::EarlyStartup();
@@ skipping 290 matching lines @@
     if (base::win::GetVersion() <= base::win::VERSION_XP)
       uma_name += "_XP";
 
     uma_name += "_PreRead_";
     uma_name += pre_read_percentage;
     AddPreReadHistogramTime(uma_name.c_str(), time);
   }
 #endif
 #endif
 }