Fix a bug that hasVideo() always returns true even after we have the size info

webkit/media/android/webmediaplayer_android.h

Index: webkit/media/android/webmediaplayer_android.h
diff --git a/webkit/media/android/webmediaplayer_android.h b/webkit/media/android/webmediaplayer_android.h
index 8118f780393259fec63321ad330ac6d79fe8b296..007e62b3b8169a341ff8e26c12ee22385d42aa89 100644
--- a/webkit/media/android/webmediaplayer_android.h
+++ b/webkit/media/android/webmediaplayer_android.h
@@ -225,6 +225,9 @@ class WebMediaPlayerAndroid
   // Whether media player needs to re-establish the surface texture peer.
   bool needs_establish_peer_;
 
+  // Whether the video size info is available.
+  bool has_size_info_;

[Miguel Garcia, 2012/11/29 20:28:02]

can you call it is_video_available_ or has video_size_ ? something that says
video on the name would be good.

[qinmin, 2012/11/29 20:39:33]

using is_video_available_ does not reflect the correct information before
OnVideoSizeChanged() is called. Before onVideoSizeChanged() gets first called,
we have to go through the whole hasVideo() code even if is_video_available is
true. Then this variable does not really reflect the correct information we
have.

On 2012/11/29 20:28:02, Miguel Garcia wrote:

[Miguel Garcia, 2012/11/29 20:43:36]

ok

On 2012/11/29 20:39:33, qinmin wrote:

+
   // Object for allocating stream textures.
   scoped_ptr<StreamTextureFactory> stream_texture_factory_;