Fix a bug that hasVideo() always returns true even after we have the size info

webkit/media/android/webmediaplayer_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
 #define WEBKIT_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
 
 #include <jni.h>
 
 #include "base/basictypes.h"
@@ skipping 207 matching lines @@
 
   // Stream texture ID allocated to the video.
   unsigned int stream_id_;
 
   // Whether the mediaplayer is playing.
   bool is_playing_;
 
   // Whether media player needs to re-establish the surface texture peer.
   bool needs_establish_peer_;
 
+  // Whether the video size info is available.
+  bool has_size_info_;

[Miguel Garcia, 2012/11/29 20:28:02]

can you call it is_video_available_ or has video_size_ ? something that says
video on the name would be good.

[qinmin, 2012/11/29 20:39:33]

using is_video_available_ does not reflect the correct information before
OnVideoSizeChanged() is called. Before onVideoSizeChanged() gets first called,
we have to go through the whole hasVideo() code even if is_video_available is
true. Then this variable does not really reflect the correct information we
have.

On 2012/11/29 20:28:02, Miguel Garcia wrote:

[Miguel Garcia, 2012/11/29 20:43:36]

ok

On 2012/11/29 20:39:33, qinmin wrote:

+
   // Object for allocating stream textures.
   scoped_ptr<StreamTextureFactory> stream_texture_factory_;
 
   // Object for calling back the compositor thread to repaint the video when a
   // frame available. It should be initialized on the compositor thread.
   scoped_ptr<StreamTextureProxy> stream_texture_proxy_;
 
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid);
 };
 
 }  // namespace webkit_media
 
 #endif  // WEBKIT_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_