Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: sync/internal_api/public/base_node.h

Issue 11412211: [sync] Componentize sync: Part Final: Target 'sync' is now its own component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on r171683 (no code changes) Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/base_node.h
diff --git a/sync/internal_api/public/base_node.h b/sync/internal_api/public/base_node.h
index b9c363d97bb49dbd3be91a593473cefbe6577693..c7ca398ac36f89c08845194c489708ed3936f2f3 100644
--- a/sync/internal_api/public/base_node.h
+++ b/sync/internal_api/public/base_node.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -13,6 +13,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/time.h"
#include "googleurl/src/gurl.h"
+#include "sync/base/sync_export.h"
#include "sync/internal_api/public/base/model_type.h"
#include "sync/protocol/sync.pb.h"
@@ -86,32 +87,32 @@ class BaseNode {
// metahandle). These ids are strictly local handles. They will persist
// on this client, but the same object on a different client may have a
// different ID value.
- virtual int64 GetId() const;
+ SYNC_EXPORT virtual int64 GetId() const;
// Returns the modification time of the object.
- base::Time GetModificationTime() const;
+ SYNC_EXPORT base::Time GetModificationTime() const;
// Nodes are hierarchically arranged into a single-rooted tree.
// InitByRootLookup on ReadNode allows access to the root. GetParentId is
// how you find a node's parent.
- int64 GetParentId() const;
+ SYNC_EXPORT int64 GetParentId() const;
// Nodes are either folders or not. This corresponds to the IS_DIR property
// of syncable::Entry.
- bool GetIsFolder() const;
+ SYNC_EXPORT bool GetIsFolder() const;
// Returns the title of the object.
// Uniqueness of the title is not enforced on siblings -- it is not an error
// for two children to share a title.
- std::string GetTitle() const;
+ SYNC_EXPORT std::string GetTitle() const;
// Returns the model type of this object. The model type is set at node
// creation time and is expected never to change.
- ModelType GetModelType() const;
+ SYNC_EXPORT ModelType GetModelType() const;
// Getter specific to the BOOKMARK datatype. Returns protobuf
// data. Can only be called if GetModelType() == BOOKMARK.
- const sync_pb::BookmarkSpecifics& GetBookmarkSpecifics() const;
+ SYNC_EXPORT const sync_pb::BookmarkSpecifics& GetBookmarkSpecifics() const;
// Getter specific to the APPS datatype. Returns protobuf
// data. Can only be called if GetModelType() == APPS.
@@ -130,7 +131,8 @@ class BaseNode {
// Getter specific to the PASSWORD datatype. Returns protobuf
// data. Can only be called if GetModelType() == PASSWORD.
- const sync_pb::PasswordSpecificsData& GetPasswordSpecifics() const;
+ SYNC_EXPORT const sync_pb::PasswordSpecificsData&
+ GetPasswordSpecifics() const;
// Getter specific to the PREFERENCE datatype. Returns protobuf
// data. Can only be called if GetModelType() == PREFERENCE.
@@ -142,7 +144,7 @@ class BaseNode {
// Getter specific to the TYPED_URLS datatype. Returns protobuf
// data. Can only be called if GetModelType() == TYPED_URLS.
- const sync_pb::TypedUrlSpecifics& GetTypedUrlSpecifics() const;
+ SYNC_EXPORT const sync_pb::TypedUrlSpecifics& GetTypedUrlSpecifics() const;
// Getter specific to the EXTENSIONS datatype. Returns protobuf
// data. Can only be called if GetModelType() == EXTENSIONS.
@@ -150,39 +152,40 @@ class BaseNode {
// Getter specific to the SESSIONS datatype. Returns protobuf
// data. Can only be called if GetModelType() == SESSIONS.
- const sync_pb::SessionSpecifics& GetSessionSpecifics() const;
+ SYNC_EXPORT const sync_pb::SessionSpecifics& GetSessionSpecifics() const;
// Getter specific to the DEVICE_INFO datatype. Returns protobuf
// data. Can only be called if GetModelType() == DEVICE_INFO.
- const sync_pb::DeviceInfoSpecifics& GetDeviceInfoSpecifics() const;
+ SYNC_EXPORT const sync_pb::DeviceInfoSpecifics&
+ GetDeviceInfoSpecifics() const;
// Getter specific to the EXPERIMENTS datatype. Returns protobuf
// data. Can only be called if GetModelType() == EXPERIMENTS.
const sync_pb::ExperimentsSpecifics& GetExperimentsSpecifics() const;
- const sync_pb::EntitySpecifics& GetEntitySpecifics() const;
+ SYNC_EXPORT const sync_pb::EntitySpecifics& GetEntitySpecifics() const;
// Returns the local external ID associated with the node.
- int64 GetExternalId() const;
+ SYNC_EXPORT int64 GetExternalId() const;
// Returns true iff this node has children.
- bool HasChildren() const;
+ SYNC_EXPORT bool HasChildren() const;
// Return the ID of the node immediately before this in the sibling order.
// For the first node in the ordering, return 0.
- int64 GetPredecessorId() const;
+ SYNC_EXPORT int64 GetPredecessorId() const;
// Return the ID of the node immediately after this in the sibling order.
// For the last node in the ordering, return 0.
- int64 GetSuccessorId() const;
+ SYNC_EXPORT int64 GetSuccessorId() const;
// Return the ID of the first child of this node. If this node has no
// children, return 0.
- int64 GetFirstChildId() const;
+ SYNC_EXPORT int64 GetFirstChildId() const;
// Returns the total number of nodes including and beneath this node.
// Recursively iterates through all children.
- int GetTotalNodeCount() const;
+ SYNC_EXPORT int GetTotalNodeCount() const;
// These virtual accessors provide access to data members of derived classes.
virtual const syncable::Entry* GetEntry() const = 0;

Powered by Google App Engine
This is Rietveld 408576698