[sync] Componentize sync: Part Final: Target 'sync' is now its own component

chrome/chrome_browser.gypi

-# Copyright 2012 The Chromium Authors. All rights reserved.
+# Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser',
       'type': 'static_library',
       'variables': { 'enable_wexit_time_destructors': 1, },
       'dependencies': [
@@ skipping 14 matching lines @@
         'safe_browsing_proto',
         'safe_browsing_report_proto',
         'variations_seed_proto',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../content/content.gyp:content_browser',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
         '../google_apis/google_apis.gyp:google_apis',
         '../media/media.gyp:media',
         '../skia/skia.gyp:skia',
-        '../sync/protocol/sync_proto.gyp:sync_proto',
+        '../sql/sql.gyp:sql',
         # TODO(akalin): Depend only on sync_api from sync.
+        '../sync/sync.gyp:sync_core',

[tim (not reviewing), 2013/01/22 23:29:59]

Can you update the todo to mention that sync_core is really (I think?) the only
thing we shouldn't be depending on, long term?

[Raghu Simha, 2013/01/23 03:43:46]

This is now moot. Targets outside sync.gyp should just depend on sync.gyp:sync
and not a list of inner targets. The real TODO here is to make sure that
sync.gyp:sync doesn't export sync_core. I've logged a bug and added a TODO in
sync.gyp.

         '../sync/sync.gyp:sync_api',
         '../sync/sync.gyp:sync_internal_api',
         '../sync/sync.gyp:sync_notifier',
-        '../ui/ui.gyp:shell_dialogs',
+        '../sync/sync.gyp:sync_proto',

[Ryan Sleevi, 2013/01/23 01:05:20]

If I understand your CL description, this should just be ../sync/sync.gyp:sync

I'm not sure why the multiple inclusions?

[Raghu Simha, 2013/01/23 03:43:46]

I had tried rationalizing this in my response to Fred's comment. See
https://codereview.chromium.org/11412211/diff/130027/chrome/chrome_browser.gy....

Now that I think about it, what you and Fred suggest makes more sense than what
I've done. I've changed this list of dependencies to just 'sync' (in this and
other files).

         '../third_party/bzip2/bzip2.gyp:bzip2',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_proto_cpp',
         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
         '../third_party/libxml/libxml.gyp:libxml',
         '../third_party/zlib/zlib.gyp:minizip',
         '../third_party/zlib/zlib.gyp:zlib',
         '../ui/base/strings/ui_strings.gyp:ui_strings',
+        '../ui/ui.gyp:shell_dialogs',
         '../ui/ui.gyp:ui',
         '../ui/ui.gyp:ui_resources',
         '../webkit/support/webkit_support.gyp:user_agent',
       ],
       'include_dirs': [
         '..',
         '<(INTERMEDIATE_DIR)',
         # Needed by pepper_flash_component_installer.cc.
         '<(SHARED_INTERMEDIATE_DIR)',
       ],
       'export_dependent_settings': [
+        '../sql/sql.gyp:sql',
         '../sync/sync.gyp:sync_notifier',

[Ryan Sleevi, 2013/01/23 01:05:20]

same here - why not ../sync/sync.gyp:sync

[Raghu Simha, 2013/01/23 03:43:46]

Done.

       ],
       'sources': [
         # All .cc, .h, .m, and .mm files under browser except for:
         # * tests and mocks.
         # * code below browser/chromeos
         # * code below browser/extensions
         'browser/about_flags.cc',
         'browser/about_flags.h',
         'browser/accessibility/accessibility_extension_api_constants.cc',
         'browser/accessibility/accessibility_extension_api_constants.h',
@@ skipping 3058 matching lines @@
           'variables': {
             'jni_gen_dir': 'chrome',
           },
           'includes': [ '../build/jni_generator.gypi' ],
         },
       ],
      },
     ],
   ],
 }