[sync] Componentize sync: Part Final: Target 'sync' is now its own component

chrome/chrome_browser.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser',
       'type': 'static_library',
       'variables': { 'enable_wexit_time_destructors': 1, },
@@ skipping 15 matching lines @@
         'safe_browsing_proto',
         'safe_browsing_report_proto',
         'variations_seed_proto',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../content/content.gyp:content_browser',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
         '../google_apis/google_apis.gyp:google_apis',
         '../media/media.gyp:media',
         '../skia/skia.gyp:skia',
-        '../sync/protocol/sync_proto.gyp:sync_proto',
+        '../sql/sql.gyp:sql',

[akalin, 2013/01/07 20:14:51]

i assume you found a direct include of something in sql/ from browser? (just
checking)

[Raghu Simha, 2013/01/08 11:27:48]

That's right. For instance, there are numerous instances of #include
"sql/connection.h" in chrome/browser. Come to think of it, I should also add
sql.gyp:sql to export_dependent_settings. Done.

         # TODO(akalin): Depend only on sync_api from sync.
+        '../sync/sync.gyp:sync_core',

[akalin, 2013/01/07 20:14:51]

confused -- why not depend on just sync.gyp:sync?  Will that be in a follow-up
patch?

[Raghu Simha, 2013/01/08 11:27:48]

In this specific case, you're right that it might make sense to depend on
sync.gyp:sync and not the individual targets since we depend on all of them.
However, the reason I didn't do so is because we'd then have to propagate the
entire set of dependencies upstream via export_dependent_settings, and that
would cause a major increase in the number of inherited dependencies by targets
that depend on browser. Right now, the only dependency we need to export is
sync_notifier.

Let me know if you disagree, or if you think I've understood it wrong.

         '../sync/sync.gyp:sync_api',
         '../sync/sync.gyp:sync_internal_api',
         '../sync/sync.gyp:sync_notifier',
+        '../sync/sync.gyp:sync_proto',
         '../third_party/bzip2/bzip2.gyp:bzip2',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',
         '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_proto_cpp',
         '../third_party/icu/icu.gyp:icui18n',
         '../third_party/icu/icu.gyp:icuuc',
         '../third_party/libxml/libxml.gyp:libxml',
         '../third_party/zlib/zlib.gyp:minizip',
         '../third_party/zlib/zlib.gyp:zlib',
         '../ui/base/strings/ui_strings.gyp:ui_strings',
         '../ui/ui.gyp:ui',
@@ skipping 3071 matching lines @@
           'variables': {
             'jni_gen_dir': 'chrome',
           },
           'includes': [ '../build/jni_generator.gypi' ],
         },
       ],
      },
     ],
   ],
 }