Chromium Code Reviews| Index: content/browser/download/download_item_impl.h |
| diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h |
| index 797c798bda9e7ab50833b635c7af1379a172d8cc..24786e887a95992f2ab87be8c5e6042adfd83055 100644 |
| --- a/content/browser/download/download_item_impl.h |
| +++ b/content/browser/download/download_item_impl.h |
| @@ -154,11 +154,6 @@ class CONTENT_EXPORT DownloadItemImpl |
| // Start the download |
| virtual void Start(scoped_ptr<DownloadFile> download_file); |
| - // If all pre-requisites have been met, complete download processing, i.e. do |
| - // internal cleanup, file rename, and potentially auto-open. (Dangerous |
| - // downloads still may block on user acceptance after this point.) |
| - virtual void MaybeCompleteDownload(); |
| - |
| // Needed because of interwining with DownloadManagerImpl -------------------- |
| // TODO(rdsmith): Unwind DownloadManagerImpl and DownloadItemImpl, |
| @@ -260,6 +255,11 @@ class CONTENT_EXPORT DownloadItemImpl |
| void OnDownloadRenamedToIntermediateName( |
| DownloadInterruptReason reason, const FilePath& full_path); |
| + // If all pre-requisites have been met, complete download processing, i.e. do |
| + // internal cleanup, file rename, and potentially auto-open. (Dangerous |
| + // downloads still may block on user acceptance after this point.) |
| + virtual void MaybeCompleteDownload(); |
|
asanka
2012/11/28 16:24:41
Does this need to be virtual anymore?
Randy Smith (Not in Mondays)
2012/11/28 20:28:26
Nope. Good catch. I nuked a couple of similar vi
|
| + |
| // Called when the download is ready to complete. |
| // This may perform final rename if necessary and will eventually call |
| // DownloadItem::Completed(). |