Made MaybeCompleteDownload private.

content/browser/download/download_item_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 136 matching lines @@
 
   // Main entry points for regular downloads, in order -------------------------
 
   // TODO(rdsmith): Fold the process that uses these fully into
   // DownloadItemImpl and pass callbacks to the delegate so that all of
   // these other than Start() can be made private.
 
   // Start the download
   virtual void Start(scoped_ptr<DownloadFile> download_file);
 
-  // If all pre-requisites have been met, complete download processing, i.e. do
-  // internal cleanup, file rename, and potentially auto-open.  (Dangerous
-  // downloads still may block on user acceptance after this point.)
-  virtual void MaybeCompleteDownload();
-
   // Needed because of interwining with DownloadManagerImpl --------------------
 
   // TODO(rdsmith): Unwind DownloadManagerImpl and DownloadItemImpl,
   // removing these from the public interface.
 
   // Notify observers that this item is being removed by the user.
   virtual void NotifyRemoved();
 
   virtual void OnDownloadedFileRemoved();
 
@@ skipping 81 matching lines @@
       TargetDisposition disposition,
       DownloadDangerType danger_type,
       const FilePath& intermediate_path);
 
   // Callback from file thread when we initialize the DownloadFile.
   void OnDownloadFileInitialized(DownloadInterruptReason result);
 
   void OnDownloadRenamedToIntermediateName(
       DownloadInterruptReason reason, const FilePath& full_path);
 
+  // If all pre-requisites have been met, complete download processing, i.e. do
+  // internal cleanup, file rename, and potentially auto-open.  (Dangerous
+  // downloads still may block on user acceptance after this point.)
+  virtual void MaybeCompleteDownload();

[asanka, 2012/11/28 16:24:41]

Does this need to be virtual anymore?

[Randy Smith (Not in Mondays), 2012/11/28 20:28:26]

Nope.  Good catch.  I nuked a couple of similar virtuals.

+
   // Called when the download is ready to complete.
   // This may perform final rename if necessary and will eventually call
   // DownloadItem::Completed().
   virtual void OnDownloadCompleting();
 
   // Called after the delegate has given the go-ahead to actually complete
   // the download.
   void ReadyForDownloadCompletionDone();
 
   void OnDownloadRenamedToFinalName(DownloadInterruptReason reason,
@@ skipping 195 matching lines @@
   const net::BoundNetLog bound_net_log_;
 
   base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_