Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1141213002: Sk4px: Difference and Exclusion (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4px: Difference and Exclusion This will cause minor (off-by-one) diffs due to a little lost precision: colortype_xfermodes mixed_xfermodes xfermodes2 xfermodeimagefilter xfermodes3 xfermodes Desktop: Xfermode_Difference_aa 9.77ms -> 7.32ms 0.75x Xfermode_Exclusion_aa 8.49ms -> 6.21ms 0.73x Xfermode_Difference 17ms -> 7.54ms 0.44x Xfermode_Exclusion 13.5ms -> 5.09ms 0.38x N7: Xfermode_Difference_aa 32.2ms -> 27.6ms 0.86x Xfermode_Difference 43.9ms -> 32ms 0.73x Xfermode_Exclusion_aa 40.5ms -> 26.7ms 0.66x Xfermode_Exclusion 71.5ms -> 23.9ms 0.33x This wraps up the xfermodes implemented in Sk4f. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0135a41e095a433414e21e37b277dab7dcbec373

Patch Set 1 #

Patch Set 2 : Keep existing precision. Still faster. #

Patch Set 3 : note on mul255Widen() #

Patch Set 4 : _none #

Patch Set 5 : back to 8-bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -8 lines) Patch
M src/core/Sk4px.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 3 4 5 chunks +23 lines, -8 lines 0 comments Download
M src/opts/Sk4px_NEON.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/opts/Sk4px_SSE2.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M src/opts/Sk4px_none.h View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141213002/80001
5 years, 7 months ago (2015-05-15 15:50:05 UTC) #2
mtklein_C
5 years, 7 months ago (2015-05-15 15:54:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 16:06:23 UTC) #6
reed1
lgtm
5 years, 7 months ago (2015-05-15 17:31:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141213002/80001
5 years, 7 months ago (2015-05-15 17:36:07 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 17:36:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0135a41e095a433414e21e37b277dab7dcbec373

Powered by Google App Engine
This is Rietveld 408576698