Issue 11412033: Rename File.readAsText to File.readAsString. There is no Text type in Dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412033: Rename File.readAsText to File.readAsString. There is no Text type in Dart (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Rename File.readAsText to File.readAsString. There is no Text type in Dart and the methods return Strings. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15011

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -46 lines)			Patch
M	pkg/intl/lib/src/file_data_reader.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/buildhook1/build.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/buildhook1/test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/buildhook2/bin/test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/buildhook2/build.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/file.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/file_error_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests/standalone/io/file_fuzz_test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/standalone/io/file_non_ascii_sync_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/file_non_ascii_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/file_test.dart	View	8 chunks	+20 lines, -20 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/apidoc/mdn/postProcess.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/apidoc/mdn/prettyPrint.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/apidoc/mdn/util.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/io.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm