Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: sdk/lib/io/file_impl.dart

Issue 11412033: Rename File.readAsText to File.readAsString. There is no Text type in Dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/file.dart ('k') | tests/standalone/io/file_error_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/file_impl.dart
diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart
index 63c161b3138389ac7edf097929b35d07372d2913..27bace995b50e412281ca066dbcb67b349dc88fc 100644
--- a/sdk/lib/io/file_impl.dart
+++ b/sdk/lib/io/file_impl.dart
@@ -609,7 +609,7 @@ class _File extends _FileBase implements File {
return result;
}
- Future<String> readAsText([Encoding encoding = Encoding.UTF_8]) {
+ Future<String> readAsString([Encoding encoding = Encoding.UTF_8]) {
_ensureFileService();
return readAsBytes().transform((bytes) {
if (bytes.length == 0) return "";
@@ -619,7 +619,7 @@ class _File extends _FileBase implements File {
});
}
- String readAsTextSync([Encoding encoding = Encoding.UTF_8]) {
+ String readAsStringSync([Encoding encoding = Encoding.UTF_8]) {
var decoder = _StringDecoders.decoder(encoding);
List<int> bytes = readAsBytesSync();
if (bytes.length == 0) return "";
« no previous file with comments | « sdk/lib/io/file.dart ('k') | tests/standalone/io/file_error_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698