Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: src/hydrogen.cc

Issue 11412007: Removed a bunch of GetExistingThreadLocal calls by threading the Isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed debugging stuff Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index ea3a070a16bcd469fda5c6eb23198d2162e24518..5af4bcf8029a548ef792e0a5bd1311bfd46e2a25 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -3237,7 +3237,8 @@ HGraph* HGraphBuilder::CreateGraph() {
// optimization. Disable optimistic LICM in that case.
Handle<Code> unoptimized_code(info()->shared_info()->code());
ASSERT(unoptimized_code->kind() == Code::FUNCTION);
- Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info());
+ Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info(),
Michael Starzinger 2012/11/15 21:24:25 I know this isn't your change, it must be somethin
Sven Panne 2012/11/16 08:24:37 Done.
+ isolate());
Handle<TypeFeedbackInfo> type_info(
Handle<TypeFeedbackInfo>::cast(maybe_type_info));
int checksum = type_info->own_type_change_checksum();
@@ -7115,7 +7116,8 @@ bool HGraphBuilder::TryInline(CallKind call_kind,
inlined_count_ += nodes_added;
ASSERT(unoptimized_code->kind() == Code::FUNCTION);
- Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info());
+ Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info(),
Michael Starzinger 2012/11/15 21:24:25 Likewise.
Sven Panne 2012/11/16 08:24:37 Done.
+ isolate());
Handle<TypeFeedbackInfo> type_info(
Handle<TypeFeedbackInfo>::cast(maybe_type_info));
graph()->update_type_change_checksum(type_info->own_type_change_checksum());
@@ -7642,7 +7644,7 @@ void HGraphBuilder::VisitCall(Call* expr) {
VariableProxy* proxy = expr->expression()->AsVariableProxy();
bool global_call = proxy != NULL && proxy->var()->IsUnallocated();
- if (proxy != NULL && proxy->var()->is_possibly_eval()) {
+ if (proxy != NULL && proxy->var()->is_possibly_eval(isolate())) {
return Bailout("possible direct call to eval");
}

Powered by Google App Engine
This is Rietveld 408576698