Removed a bunch of GetExistingThreadLocal calls by threading the Isolate.

src/hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3219 matching lines @@
       current_block()->FinishExit(instr);
       set_current_block(NULL);
     }
 
     // If the checksum of the number of type info changes is the same as the
     // last time this function was compiled, then this recompile is likely not
     // due to missing/inadequate type feedback, but rather too aggressive
     // optimization. Disable optimistic LICM in that case.
     Handle<Code> unoptimized_code(info()->shared_info()->code());
     ASSERT(unoptimized_code->kind() == Code::FUNCTION);
-    Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info());
+    Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info(),

[Michael Starzinger, 2012/11/15 21:24:25]

I know this isn't your change, it must be something pretty recent. But I really
don't like this maybe-handle pattern. The following is much easier to read and
doesn't need an explicit isolate parameter.

Handle<TypeFeedbackInfo> type_info(
    TypeFeedbackInfo::cast(unoptimized_code->type_feedback_info()));

[Sven Panne, 2012/11/16 08:24:37]

Done.

+                                   isolate());
     Handle<TypeFeedbackInfo> type_info(
         Handle<TypeFeedbackInfo>::cast(maybe_type_info));
     int checksum = type_info->own_type_change_checksum();
     int composite_checksum = graph()->update_type_change_checksum(checksum);
     graph()->set_use_optimistic_licm(
         !type_info->matches_inlined_type_change_checksum(composite_checksum));
     type_info->set_inlined_type_change_checksum(composite_checksum);
   }
 
   return graph();
@@ skipping 3857 matching lines @@
     target_shared->DisableOptimization("inlining bailed out");
     inline_bailout_ = true;
     delete target_state;
     return true;
   }
 
   // Update inlined nodes count.
   inlined_count_ += nodes_added;
 
   ASSERT(unoptimized_code->kind() == Code::FUNCTION);
-  Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info());
+  Handle<Object> maybe_type_info(unoptimized_code->type_feedback_info(),

[Michael Starzinger, 2012/11/15 21:24:25]

Likewise.

[Sven Panne, 2012/11/16 08:24:37]

Done.

+                                 isolate());
   Handle<TypeFeedbackInfo> type_info(
       Handle<TypeFeedbackInfo>::cast(maybe_type_info));
   graph()->update_type_change_checksum(type_info->own_type_change_checksum());
 
   TraceInline(target, caller, NULL);
 
   if (current_block() != NULL) {
     FunctionState* state = function_state();
     if (state->inlining_kind() == CONSTRUCT_CALL_RETURN) {
       // Falling off the end of an inlined construct call. In a test context the
@@ skipping 506 matching lines @@
       HValue* context = environment()->LookupContext();
       call = PreProcessCall(
           new(zone()) HCallNamed(context, name, argument_count));
     }
 
   } else {
     expr->RecordTypeFeedback(oracle(), CALL_AS_FUNCTION);
     VariableProxy* proxy = expr->expression()->AsVariableProxy();
     bool global_call = proxy != NULL && proxy->var()->IsUnallocated();
 
-    if (proxy != NULL && proxy->var()->is_possibly_eval()) {
+    if (proxy != NULL && proxy->var()->is_possibly_eval(isolate())) {
       return Bailout("possible direct call to eval");
     }
 
     if (global_call) {
       Variable* var = proxy->var();
       bool known_global_function = false;
       // If there is a global property cell for the name at compile time and
       // access check is not enabled we assume that the function will not change
       // and generate optimized code for calling the function.
       LookupResult lookup(isolate());
@@ skipping 2381 matching lines @@
     }
   }
 
 #ifdef DEBUG
   if (graph_ != NULL) graph_->Verify(false);  // No full verify.
   if (allocator_ != NULL) allocator_->Verify();
 #endif
 }
 
 } }  // namespace v8::internal