Fix for issue 7089 (Symbols::New was not quite working correctly

vm/symbols.h

Index: vm/symbols.h
===================================================================
--- vm/symbols.h	(revision 15670)
+++ vm/symbols.h	(working copy)
@@ -177,10 +177,19 @@
   // Get number of symbols in an isolate's symbol table.
   static intptr_t Size(Isolate* isolate);
 
-  // Helper functions to create a symbol given a string or set of characters.
-  static RawString* New(const char* str);
-  template<typename T>
-  static RawString* New(const T* characters, intptr_t len);
+  // Creates a Symbol given a C string that is assumed to contain
+  // UTF-8 encoded characters and '\0' is considered a termination character.
+  static RawString* New(const char* cstr);
+
+  // Creates a new Symbol from an array of UTF-8 encoded characters.

[cshapiro, 2012/12/04 00:41:07]

This comment needs to be updated.

  // Creates a new Symbol from an array of Latin-1 encoded characters.

[siva, 2012/12/04 00:55:57]

This has changed some.

On 2012/12/04 00:41:07, cshapiro wrote:

+  static RawString* New(const uint8_t* utf8_array, intptr_t len);
+
+  // Creates a new Symbol from an array of UTF-16 encoded characters.
+  static RawString* New(const uint16_t* utf16_array, intptr_t len);
+
+  // Creates a new Symbol from an array of UTF-32 encoded characters.
+  static RawString* New(const int32_t* utf32_array, intptr_t len);
+
   static RawString* New(const String& str);
   static RawString* New(const String& str,
                         intptr_t begin_index,
@@ -201,6 +210,10 @@
     kInitialSymtabSize = 256
   };
 
+  // Helper functions to create a symbol given a string or set of characters.
+  template<typename T>
+  static RawString* NewSymbol(const T* characters, intptr_t len);
+
   // Add the string into the VM isolate symbol table.
   static void Add(const Array& symbol_table, const String& str);