vm/dart_api_impl.cc - Issue 11411341: Fix for issue 7089 (Symbols::New was not quite working correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/dart_api_impl.cc

Issue 11411341: Fix for issue 7089 (Symbols::New was not quite working correctly (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/dart_api_impl.cc

===================================================================

--- vm/dart_api_impl.cc (revision 15670)

+++ vm/dart_api_impl.cc (working copy)

@@ -1562,7 +1562,7 @@

return Api::NewError("%s expects argument 'str' to be valid UTF-8.",

CURRENT_FUNC);

}

- return Api::NewHandle(isolate, String::New(utf8_array, length));

+ return Api::NewHandle(isolate, String::NewFromUTF8(utf8_array, length));

cshapiro 2012/12/04 00:41:07 This should cause a compile time error as NewFromU

siva 2012/12/04 00:55:57 Done.

}

« no previous file with comments | « no previous file | vm/double_conversion.cc » ('j') | vm/symbols.h » ('J')