Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: vm/object.h

Issue 11411341: Fix for issue 7089 (Symbols::New was not quite working correctly (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/double_conversion.cc ('k') | vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object.h
===================================================================
--- vm/object.h (revision 15671)
+++ vm/object.h (working copy)
@@ -3819,19 +3819,28 @@
// Creates a new String object from a C string that is assumed to contain
// UTF-8 encoded characters and '\0' is considered a termination character.
+ // TODO(7123) - Rename this to FromCString(....).
static RawString* New(const char* cstr, Heap::Space space = Heap::kNew);
// Creates a new String object from an array of UTF-8 encoded characters.
- static RawString* New(const uint8_t* utf8_array,
+ static RawString* FromUTF8(const uint8_t* utf8_array,
+ intptr_t array_len,
+ Heap::Space space = Heap::kNew);
+
+ // Creates a new String object from an array of Latin-1 encoded characters.
+ // TODO(7123) - Rename this to FromLatin1(....).
+ static RawString* New(const uint8_t* latin1_array,
intptr_t array_len,
Heap::Space space = Heap::kNew);
// Creates a new String object from an array of UTF-16 encoded characters.
+ // TODO(7123) - Rename this to FromUTF16(....).
static RawString* New(const uint16_t* utf16_array,
intptr_t array_len,
Heap::Space space = Heap::kNew);
// Creates a new String object from an array of UTF-32 encoded characters.
+ // TODO(7123) - Rename this to FromUTF32(....).
static RawString* New(const int32_t* utf32_array,
intptr_t array_len,
Heap::Space space = Heap::kNew);
@@ -3916,7 +3925,7 @@
raw_ptr()->hash_ = Smi::New(value);
}
- template<typename HandleType, typename ElementType>
+ template<typename StringType, typename CharacterType>
static void ReadFromImpl(SnapshotReader* reader,
String* str_obj,
intptr_t len,
« no previous file with comments | « vm/double_conversion.cc ('k') | vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698