Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: vm/double_conversion.cc

Issue 11411341: Fix for issue 7089 (Symbols::New was not quite working correctly (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/dart_api_impl.cc ('k') | vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/double_conversion.cc
===================================================================
--- vm/double_conversion.cc (revision 15671)
+++ vm/double_conversion.cc (working copy)
@@ -91,8 +91,7 @@
double_conversion::StringBuilder builder(buffer, kBufferSize);
bool status = converter.ToFixed(d, fraction_digits, &builder);
ASSERT(status);
- int length = builder.position();
- return String::New(reinterpret_cast<uint8_t*>(builder.Finalize()), length);
+ return String::New(builder.Finalize());
}
@@ -125,8 +124,7 @@
double_conversion::StringBuilder builder(buffer, kBufferSize);
bool status = converter.ToExponential(d, fraction_digits, &builder);
ASSERT(status);
- int length = builder.position();
- return String::New(reinterpret_cast<uint8_t*>(builder.Finalize()), length);
+ return String::New(builder.Finalize());
}
@@ -165,8 +163,7 @@
double_conversion::StringBuilder builder(buffer, kBufferSize);
bool status = converter.ToPrecision(d, precision, &builder);
ASSERT(status);
- int length = builder.position();
- return String::New(reinterpret_cast<uint8_t*>(builder.Finalize()), length);
+ return String::New(builder.Finalize());
}
} // namespace dart
« no previous file with comments | « vm/dart_api_impl.cc ('k') | vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698