Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 11411329: Merge 168106 (Closed)

Created:
8 years ago by DaleCurtis
Modified:
8 years ago
Reviewers:
Dale Curtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 168106 > Reduce high latency input buffers to 1. > > Multiple buffers lead to trampling input data which is in the process > of being transmitted across the shared memory. > > Since this API was never intended for low latency usage, clients should > instead use a larger buffer size. At least 2048 @ 44.1kHz (Flash) and > 1600 at 16kHz (speech recognizer). > > vtl will land a fix to flash along side this change to move it off of the > RecommendSampleCount() method to a hard coded 2048 frame buffer. > > NOTRY=true > BUG=157613 > TEST=input is clear and crisp w/ flash @ 2048 buffer. > > Review URL: https://codereview.chromium.org/11418017 TBR=dalecurtis@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/audio/mac/audio_input_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
DaleCurtis
8 years ago (2012-12-03 21:04:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698