Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 11418017: Reduce high latency input buffers to 1. (Closed)

Created:
8 years, 1 month ago by DaleCurtis
Modified:
8 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, sail+watch_chromium.org, viettrungluu
Visibility:
Public.

Description

Reduce high latency input buffers to 1. Multiple buffers lead to trampling input data which is in the process of being transmitted across the shared memory. Since this API was never intended for low latency usage, clients should instead use a larger buffer size. At least 2048 @ 44.1kHz (Flash) and 1600 at 16kHz (speech recognizer). vtl will land a fix to flash along side this change to move it off of the RecommendSampleCount() method to a hard coded 2048 frame buffer. NOTRY=true BUG=157613 TEST=input is clear and crisp w/ flash @ 2048 buffer. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/audio/mac/audio_input_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
8 years, 1 month ago (2012-11-15 23:45:11 UTC) #1
scherkus (not reviewing)
lgtm
8 years, 1 month ago (2012-11-16 00:03:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11418017/1
8 years, 1 month ago (2012-11-16 01:05:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11418017/1
8 years, 1 month ago (2012-11-16 01:36:52 UTC) #4
henrika (OOO until Aug 14)
8 years, 1 month ago (2012-11-16 09:38:10 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698