Issue 11411282: [content shell] add support for testRunner.canOpenWindows and disallow opening windows per default …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411282: [content shell] add support for testRunner.canOpenWindows and disallow opening windows per default … (Closed)

Created:
8 years ago by jochen (gone - plz use gerrit)

Modified:
8 years ago

Reviewers:
marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[content shell] add support for testRunner.canOpenWindows and disallow opening windows per default for layout tests BUG=111316 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170451

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
M	content/shell/shell_content_browser_client.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/shell/shell_content_browser_client.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	content/shell/shell_messages.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/webkit_test_runner.js	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/shell/webkit_test_runner_bindings.cc	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	content/shell/webkit_test_runner_host.h	View	1	3 chunks	+6 lines, -0 lines	0 comments	Download
M	content/shell/webkit_test_runner_host.cc	View	1	3 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

8 years ago (2012-11-30 13:16:24 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/11411282/4001