Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: content/shell/webkit_test_runner_host.h

Issue 11411282: [content shell] add support for testRunner.canOpenWindows and disallow opening windows per default … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/webkit_test_runner_bindings.cc ('k') | content/shell/webkit_test_runner_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/webkit_test_runner_host.h
diff --git a/content/shell/webkit_test_runner_host.h b/content/shell/webkit_test_runner_host.h
index 596a910dbd6bbf5d655f0086e3767e90fed75e52..ed4843984de3b08521ca6e67e775957439b8418e 100644
--- a/content/shell/webkit_test_runner_host.h
+++ b/content/shell/webkit_test_runner_host.h
@@ -109,6 +109,10 @@ class WebKitTestController : public base::NonThreadSafe,
}
bool is_printing() const { return is_printing_; }
void set_is_printing(bool is_printing) { is_printing_ = is_printing; }
+ bool can_open_windows() const { return can_open_windows_; }
+ void set_can_open_windows(bool can_open_windows) {
+ can_open_windows_ = can_open_windows;
+ }
// WebContentsObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
@@ -146,6 +150,7 @@ class WebKitTestController : public base::NonThreadSafe,
bool is_printing_;
bool should_stay_on_page_after_handling_before_unload_;
bool wait_until_done_;
+ bool can_open_windows_;
ShellWebPreferences prefs_;
base::CancelableClosure watchdog_;
@@ -169,6 +174,7 @@ class WebKitTestRunnerHost : public RenderViewHostObserver {
void OnSetPrinting();
void OnSetShouldStayOnPageAfterHandlingBeforeUnload(bool should_stay_on_page);
void OnWaitUntilDone();
+ void OnCanOpenWindows();
void OnNotImplemented(const std::string& object_name,
const std::string& method_name);
« no previous file with comments | « content/shell/webkit_test_runner_bindings.cc ('k') | content/shell/webkit_test_runner_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698