Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 11411229: [Android] Implement WebSettings.setAppCache{Enabled|Path} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed a spurious include Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index e579e2287770023eaf9a3bcbd5361d594714e60a..8a1f1e302bca066e533f10a505fcdb4d754dd2e2 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -114,9 +114,9 @@ gfx::ImageSkia* AwContentBrowserClient::GetDefaultFavicon() {
bool AwContentBrowserClient::AllowAppCache(const GURL& manifest_url,
const GURL& first_party,
content::ResourceContext* context) {
- // TODO(boliu): Implement this to power WebSettings.SetAppCacheEnabled.
- NOTIMPLEMENTED();
- return false;
+ // WebView doesn't have a per-site policy for locally stored data,
+ // instead AppCache can be disabled for the whole WebView instance.
joth 2012/11/30 22:16:59 nit: whole WV instance, or whole application?
mnaganov (inactive) 2012/12/03 15:07:36 Per instance. Reworded to avoid confusion.
+ return true;
}

Powered by Google App Engine
This is Rietveld 408576698