[Android] Implement WebSettings.setAppCache{Enabled|Path}

android_webview/browser/aw_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include "android_webview/browser/aw_browser_main_parts.h"
 #include "android_webview/browser/aw_cookie_access_policy.h"
 #include "android_webview/browser/aw_quota_permission_context.h"
 #include "android_webview/browser/net_disk_cache_remover.h"
@@ skipping 96 matching lines @@
 
 gfx::ImageSkia* AwContentBrowserClient::GetDefaultFavicon() {
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   // TODO(boliu): Bundle our own default favicon?
   return rb.GetImageSkiaNamed(IDR_DEFAULT_FAVICON);
 }
 
 bool AwContentBrowserClient::AllowAppCache(const GURL& manifest_url,
                            const GURL& first_party,
                            content::ResourceContext* context) {
-  // TODO(boliu): Implement this to power WebSettings.SetAppCacheEnabled.
-  NOTIMPLEMENTED();
-  return false;
+  // WebView doesn't have a per-site policy for locally stored data,
+  // instead AppCache can be disabled for the whole WebView instance.

[joth, 2012/11/30 22:16:59]

nit: whole WV instance, or whole application?

[mnaganov (inactive), 2012/12/03 15:07:36]

Per instance. Reworded to avoid confusion.

+  return true;
 }
 
 
 bool AwContentBrowserClient::AllowGetCookie(const GURL& url,
                                             const GURL& first_party,
                                             const net::CookieList& cookie_list,
                                             content::ResourceContext* context,
                                             int render_process_id,
                                             int render_view_id) {
   return AwCookieAccessPolicy::GetInstance()->AllowGetCookie(url,
@@ skipping 188 matching lines @@
 
 bool AwContentBrowserClient::AllowPepperSocketAPI(
     content::BrowserContext* browser_context,
     const GURL& url,
     const content::SocketPermissionRequest& params) {
   NOTREACHED() << "Android WebView does not support plugins";
   return false;
 }
 
 }  // namespace android_webview