compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 11411146: Issue 6866. Report not-implemented-in-concrete class warnings if there are members without body.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 11411146: Issue 6866. Report not-implemented-in-concrete class warnings if there are members without body. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Resolver.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index e6a64192bc157bc25fe7e5e5c2f6f79d60d4c825..ea351cac8b70fb846de97f6cbe34821ef1286ff1 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -3147,7 +3147,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

Set<String> artificialNames = Sets.newHashSet();

for (ClassElement interfaceElement : typesForAbstractMembers) {

for (Element member : interfaceElement.getMembers()) {

- if (interfaceElement == currentClass.getElement() && !member.getModifiers().isAbstract()) {

+ if (interfaceElement == currentClass.getElement() && !Elements.isAbstractElement(member)) {

continue;

}

String name = member.getName();

@@ -3188,7 +3188,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

ClassElement superclass = supertype.getElement();

for (Element member : superclass.getMembers()) {

String name = member.getName();

- if (!member.getModifiers().isAbstract()) {

+ if (!Elements.isAbstractElement(member)) {

superMembers.removeAll(name);

}

if (member instanceof FieldElement) {

@@ -3219,7 +3219,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

// add abstract members of current class

for (Element member : currentClass.getElement().getMembers()) {

- if (member.getModifiers().isAbstract()) {

+ if (Elements.isAbstractElement(member)) {

unimplementedElements.add(member);

}