compiler/java/com/google/dart/compiler/resolver/Resolver.java - Issue 11411146: Issue 6866. Report not-implemented-in-concrete class warnings if there are members without body.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 11411146: Issue 6866. Report not-implemented-in-concrete class warnings if there are members without body. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Elements.java ('k') | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

index 88b06e4a809b4e916536e34b866ca9553b952117..41276754c6591343c698b1ceda4f3e8ff8cad2a1 100644

--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

@@ -732,11 +732,12 @@ public class Resolver {

if (body == null) {

if (member.getModifiers().isStatic() && !member.getModifiers().isExternal()) {

onError(functionNode, ResolverErrorCode.STATIC_METHOD_MUST_HAVE_BODY);

- } else if (!Elements.isNonFactoryConstructor(member) && !member.getModifiers().isAbstract()

- && !member.getModifiers().isExternal() && node.getRedirectedTypeName() == null

- && !(isInterface || isAbstractClass)) {

- onError(functionNode, ResolverErrorCode.METHOD_MUST_HAVE_BODY);

}

+// else if (!Elements.isNonFactoryConstructor(member) && !member.getModifiers().isAbstract()

+// && !member.getModifiers().isExternal() && node.getRedirectedTypeName() == null

+// && !(isInterface || isAbstractClass)) {

+// onError(functionNode, ResolverErrorCode.METHOD_MUST_HAVE_BODY);

+// }

}

resolve(functionNode.getBody());