Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: tests/standalone/io/http_auth_test.dart

Issue 11411121: Generate an error for active connections when the HTTP client is shutdown (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed long line Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/http_auth_test.dart
diff --git a/tests/standalone/io/http_auth_test.dart b/tests/standalone/io/http_auth_test.dart
index 7347b5d4fd9b8723ce821883d63e6bc3a17d633f..07705de26b91c426cd4c7ef73d21ba0cf8894cda 100644
--- a/tests/standalone/io/http_auth_test.dart
+++ b/tests/standalone/io/http_auth_test.dart
@@ -80,8 +80,11 @@ void testUrlUserInfo() {
new Uri.fromString(
"http://username:password@127.0.0.1:${server.port}/"));
conn.onResponse = (HttpClientResponse response) {
- server.shutdown();
- client.shutdown();
+ response.inputStream.onData = response.inputStream.read;
+ response.inputStream.onClosed = () {
+ server.shutdown();
+ client.shutdown();
+ };
};
}
@@ -94,7 +97,8 @@ void testBasicNoCredentials() {
HttpClientConnection conn = client.getUrl(url);
conn.onResponse = (HttpClientResponse response) {
Expect.equals(HttpStatus.UNAUTHORIZED, response.statusCode);
- completer.complete(null);
+ response.inputStream.onData = response.inputStream.read;
+ response.inputStream.onClosed = () => completer.complete(null);
};
return completer.future;
}
@@ -123,7 +127,8 @@ void testBasicCredentials() {
HttpClientConnection conn = client.getUrl(url);
conn.onResponse = (HttpClientResponse response) {
Expect.equals(HttpStatus.OK, response.statusCode);
- completer.complete(null);
+ response.inputStream.onData = response.inputStream.read;
+ response.inputStream.onClosed = () => completer.complete(null);
};
return completer.future;
}
@@ -175,7 +180,8 @@ void testBasicAuthenticateCallback() {
HttpClientConnection conn = client.getUrl(url);
conn.onResponse = (HttpClientResponse response) {
Expect.equals(HttpStatus.OK, response.statusCode);
- completer.complete(null);
+ response.inputStream.onData = response.inputStream.read;
+ response.inputStream.onClosed = () => completer.complete(null);
};
return completer.future;
}

Powered by Google App Engine
This is Rietveld 408576698