Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: sdk/lib/io/http.dart

Issue 11411121: Generate an error for active connections when the HTTP client is shutdown (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed long line Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg.status ('k') | sdk/lib/io/http_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http.dart
diff --git a/sdk/lib/io/http.dart b/sdk/lib/io/http.dart
index bcfa93302b8f713c737c605b756584dec5068285..036ace319f0a1e2796ec011e487e1d6c49254510 100644
--- a/sdk/lib/io/http.dart
+++ b/sdk/lib/io/http.dart
@@ -830,9 +830,12 @@ abstract class HttpClient {
set findProxy(String f(Uri url));
/**
- * Shutdown the HTTP client releasing all resources.
+ * Shutdown the HTTP client. If [force] is [:true:] any active
+ * connections will be terminated to immediately release all
+ * resources. If [force] is [:false:] the [:HttpClient:] will be
Mads Ager (google) 2012/11/23 07:25:38 Could we add a comment to make it explicit what ha
Søren Gjesse 2012/11/23 09:08:47 It's already there, "If [force] is [:true:]..." ab
Søren Gjesse 2012/11/23 09:31:16 Added more information on forced shutdown.
+ * kept alive until all active connections are done.
*/
- void shutdown();
+ void shutdown({bool force: false});
}
« no previous file with comments | « pkg/pkg.status ('k') | sdk/lib/io/http_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698