Issue 11411023: Merge 165818 - [Win8] Fix pin / unpin status if the user cancels an action or pins / unpins from st…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411023: Merge 165818 - [Win8] Fix pin / unpin status if the user cancels an action or pins / unpins from st… (Closed)

Created:
8 years, 1 month ago by benwells

Modified:
8 years, 1 month ago

Reviewers:
benwells

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1312/src/

Visibility:
Public.

Merge 165818 - [Win8] Fix pin / unpin status if the user cancels an action or pins / unpins from start screen. Previously the state was cached whenever a navigation happened, or whenever the user started a pin / unpin action. As the state query does not happen on the metro thread (it happens on the UI thread and is synchronous) there is no need for the caching. BUG=144332 Review URL: https://chromiumcodereview.appspot.com/11362050 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168089

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -38 lines)			Patch
M	chrome/browser/ui/metro_pin_tab_helper_win.h	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/ui/metro_pin_tab_helper_win.cc	View	3 chunks	+20 lines, -30 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)