Chromium Code Reviews
Help | Chromium Project | Sign in
(4)

Issue 11410046: Object.deliverChangeRecords should remove the observer from activeObservers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by adamk
Modified:
2 years, 6 months ago
Reviewers:
rafaelw, rossberg
CC:
v8-dev, rafaelw
Visibility:
Public.

Description

Object.deliverChangeRecords should remove the observer from activeObservers To preserve ordering guarantees during end-of-turn delivery, Object.deliverChangeRecords needs to remove the delivered-to observer from the list of active observers. The added test demonstrates this behavior. Committed: https://code.google.com/p/v8/source/detail?r=12951

Patch Set 1 #

Patch Set 2 : Rename activeObservers to pendingObservers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M src/object-observe.js View 1 4 chunks +8 lines, -7 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +24 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
adamk
2 years, 6 months ago (2012-11-12 22:56:36 UTC) #1
rafaelw
lgtm. good catch.
2 years, 6 months ago (2012-11-12 23:02:15 UTC) #2
rossberg
LGTM. Btw, nit: can we perhaps rename 'activeObservers' to 'pendingObservers', in analogy with pendingChangeRecords? I ...
2 years, 6 months ago (2012-11-13 10:35:02 UTC) #3
adamk
2 years, 6 months ago (2012-11-13 13:34:32 UTC) #4
Renamed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be