Chromium Code Reviews
Help | Chromium Project | Sign in
(383)

Issue 11410046: Object.deliverChangeRecords should remove the observer from activeObservers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by adamk
Modified:
1 year, 5 months ago
Reviewers:
rafaelw, rossberg
CC:
v8-dev_googlegroups.com, rafaelw
Visibility:
Public.

Description

Object.deliverChangeRecords should remove the observer from activeObservers

To preserve ordering guarantees during end-of-turn delivery, Object.deliverChangeRecords needs to remove the delivered-to observer from the list of active observers.

The added test demonstrates this behavior.

Committed: https://code.google.com/p/v8/source/detail?r=12951

Patch Set 1 #

Patch Set 2 : Rename activeObservers to pendingObservers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Lint Patch
M src/object-observe.js View 1 4 chunks +8 lines, -7 lines 0 comments ? errors Download
M test/cctest/test-object-observe.cc View 1 chunk +24 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 4
adamk
1 year, 5 months ago #1
rafaelw
lgtm. good catch.
1 year, 5 months ago #2
rossberg
LGTM. Btw, nit: can we perhaps rename 'activeObservers' to 'pendingObservers', in analogy with pendingChangeRecords? I ...
1 year, 5 months ago #3
adamk
1 year, 5 months ago #4
Renamed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6