utils/template/codegen.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/template/codegen.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment in https://codereview.chromium.org/11365196/diff/6001/pkg/intl/lib/date_format.dart Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/template/codegen.dart

diff --git a/utils/template/codegen.dart b/utils/template/codegen.dart

index a622fba74456df5406663c3ff6308a30d4e49840..6f566a6db14d9a020bd9b986586f0e8fe85d064e 100644

--- a/utils/template/codegen.dart

+++ b/utils/template/codegen.dart

@@ -501,7 +501,7 @@ class Codegen {

class ElemCG {

// List of identifiers and quoted strings (single and double quoted).

- var identRe = const RegExp(

+ var identRe = new RegExp(

"\s*('\"\\'\\\"[^'\"\\'\\\"]+'\"\\'\\\"|[_A-Za-z][_A-Za-z0-9]*)");

List<CGBlock> _cgBlocks;