Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140983002: remove color from GrGeometryProcessor (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove color from GrGeometryProcessor BUG=skia: Committed: https://skia.googlesource.com/skia/+/88c23fc6e8ed0243159fd17d815b4f813805647b

Patch Set 1 #

Patch Set 2 : more #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -42 lines) Patch
M gm/beziereffects.cpp View 11 chunks +19 lines, -6 lines 3 comments Download
M gm/convexpolyeffect.cpp View 4 chunks +9 lines, -4 lines 1 comment Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 3 chunks +4 lines, -1 line 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 3 chunks +4 lines, -1 line 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 3 chunks +1 line, -10 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 9 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 2 chunks +2 lines, -1 line 1 comment Download
M src/gpu/effects/GrBezierEffect.h View 1 6 chunks +11 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 3 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 6 chunks +12 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 1 6 chunks +8 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joshualitt
straightforward CL to remove color off GrGeometryProcessor base class.
5 years, 7 months ago (2015-05-13 20:01:01 UTC) #2
robertphillips
https://codereview.chromium.org/1140983002/diff/20001/gm/beziereffects.cpp File gm/beziereffects.cpp (right): https://codereview.chromium.org/1140983002/diff/20001/gm/beziereffects.cpp#newcode145 gm/beziereffects.cpp:145: int col = 0; Use SK_ColorBLACK ? https://codereview.chromium.org/1140983002/diff/20001/gm/beziereffects.cpp#newcode293 gm/beziereffects.cpp:293: ...
5 years, 7 months ago (2015-05-13 20:33:50 UTC) #3
robertphillips
lgtm
5 years, 7 months ago (2015-05-13 21:07:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140983002/20001
5 years, 7 months ago (2015-05-13 21:09:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 21:18:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/88c23fc6e8ed0243159fd17d815b4f813805647b

Powered by Google App Engine
This is Rietveld 408576698