Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: src/gpu/GrGeometryProcessor.h

Issue 1140983002: remove color from GrGeometryProcessor (Closed) Base URL: https://skia.googlesource.com/skia.git@cleanup2
Patch Set: more Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/GrGeometryProcessor.h
diff --git a/src/gpu/GrGeometryProcessor.h b/src/gpu/GrGeometryProcessor.h
index c380f20b0ed7ca1ebbbfeea9b69e6941f8b3b4b0..1c7fc9989bb473af5c0ce0639157c07fef62ee32 100644
--- a/src/gpu/GrGeometryProcessor.h
+++ b/src/gpu/GrGeometryProcessor.h
@@ -19,13 +19,9 @@
*/
class GrGeometryProcessor : public GrPrimitiveProcessor {
public:
- // TODO the Hint can be handled in a much more clean way when we have deferred geometry or
- // atleast bundles
- GrGeometryProcessor(GrColor color,
- const SkMatrix& viewMatrix = SkMatrix::I(),
+ GrGeometryProcessor(const SkMatrix& viewMatrix = SkMatrix::I(),
const SkMatrix& localMatrix = SkMatrix::I())
: INHERITED(viewMatrix, localMatrix, false)
- , fColor(color)
, fWillUseGeoShader(false)
, fHasLocalCoords(false) {}
@@ -38,10 +34,6 @@ public:
SkFAIL("Unsupported\n");
return false;
}
-
- // TODO we can remove color from the GrGeometryProcessor base class once we have bundles of
- // primitive data
- GrColor color() const { return fColor; }
// TODO Delete when paths are in batch
void getInvariantOutputColor(GrInitInvariantOutput* out) const override {
@@ -105,7 +97,6 @@ protected:
private:
bool hasExplicitLocalCoords() const override { return fHasLocalCoords; }
- GrColor fColor;
bool fWillUseGeoShader;
bool fHasLocalCoords;

Powered by Google App Engine
This is Rietveld 408576698