Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: ppapi/tests/test_case.cc

Issue 1140953003: PPAPI Testing: Clean up location of ppapi::StripTestPrefixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to shared_impl Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/unittest_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_case.cc
diff --git a/ppapi/tests/test_case.cc b/ppapi/tests/test_case.cc
index a2575560ca3cf916450fd8acb23aed4642b84c33..307dd387540e744a59a5ff021641dd3ad972343b 100644
--- a/ppapi/tests/test_case.cc
+++ b/ppapi/tests/test_case.cc
@@ -18,11 +18,8 @@
namespace {
std::string StripPrefix(const std::string& test_name) {
raymes 2015/05/14 01:53:47 Can we remove this function and just call the vers
raymes 2015/05/14 01:55:01 Ahh we can't do this because of DEPS.
tommycli 2015/05/14 17:44:23 Yes, I tried very hard. (see PS1 heh)
- const char* const prefixes[] = {
- "FAILS_", "FLAKY_", "DISABLED_" };
- for (size_t i = 0; i < sizeof(prefixes)/sizeof(prefixes[0]); ++i)
- if (test_name.find(prefixes[i]) == 0)
- return test_name.substr(strlen(prefixes[i]));
+ if (test_name.find("DISABLED_") == 0)
+ return test_name.substr(strlen("DISABLED_"));
return test_name;
}
« no previous file with comments | « ppapi/shared_impl/unittest_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698