PPAPI Testing: Clean up location of ppapi::StripTestPrefixes

ppapi/tests/test_case.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_case.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <sstream>
 
 #include "ppapi/cpp/core.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/tests/pp_thread.h"
 #include "ppapi/tests/test_utils.h"
 #include "ppapi/tests/testing_instance.h"
 
 namespace {
 
 std::string StripPrefix(const std::string& test_name) {

[raymes, 2015/05/14 01:53:47]

Can we remove this function and just call the version in
ppapi/shared_impl/test_utils.cc?

[raymes, 2015/05/14 01:55:01]

Ahh we can't do this because of DEPS.

[tommycli, 2015/05/14 17:44:23]

Yes, I tried very hard. (see PS1 heh)

-  const char* const prefixes[] = {
-      "FAILS_", "FLAKY_", "DISABLED_" };
-  for (size_t i = 0; i < sizeof(prefixes)/sizeof(prefixes[0]); ++i)
-    if (test_name.find(prefixes[i]) == 0)
-      return test_name.substr(strlen(prefixes[i]));
+  if (test_name.find("DISABLED_") == 0)
+    return test_name.substr(strlen("DISABLED_"));
   return test_name;
 }
 
 // Strip the TestCase name off and return the remainder (i.e., everything after
 // '_'). If there is no '_', assume only the TestCase was provided, and return
 // an empty string.
 // For example:
 //   StripTestCase("TestCase_TestName");
 // returns
 //   "TestName"
@@ skipping 215 matching lines @@
     void (*thread_func)(void*),
     void* thread_param,
     const PPB_Testing_Private* testing_interface) {
   PP_Thread thread;
   PP_CreateThread(&thread, thread_func, thread_param);
   // Run a message loop so pepper calls can be dispatched. The background
   // thread will set result_ and make us Quit when it's done.
   testing_interface->RunMessageLoop(instance_->pp_instance());
   PP_JoinThread(thread);
 }