Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1140953003: PPAPI Testing: Clean up location of ppapi::StripTestPrefixes (Closed)

Created:
5 years, 7 months ago by tommycli
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI Testing: Clean up location of ppapi::StripTestPrefixes BUG=478309 Committed: https://crrev.com/a88b609ba9a3df0f5cb9950a0564c9ee463f6f69 Cr-Commit-Position: refs/heads/master@{#329874}

Patch Set 1 #

Patch Set 2 : move to shared_impl #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -264 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/ppapi_test_utils.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/test/ppapi_test_utils.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/ppapi/ppapi_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/raw_var_data_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + ppapi/shared_impl/test_utils.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
A + ppapi/shared_impl/test_utils.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
D ppapi/shared_impl/unittest_utils.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D ppapi/shared_impl/unittest_utils.cc View 1 1 chunk +0 lines, -212 lines 0 comments Download
M ppapi/tests/test_case.cc View 1 1 chunk +2 lines, -5 lines 3 comments Download

Messages

Total messages: 18 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140953003/1
5 years, 7 months ago (2015-05-13 22:40:17 UTC) #3
tommycli
phajdan.jr, raymes: PTAL small CL thanks!
5 years, 7 months ago (2015-05-13 22:40:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63472)
5 years, 7 months ago (2015-05-13 22:48:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140953003/20001
5 years, 7 months ago (2015-05-14 00:11:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-14 01:11:42 UTC) #10
raymes
https://codereview.chromium.org/1140953003/diff/20001/ppapi/tests/test_case.cc File ppapi/tests/test_case.cc (right): https://codereview.chromium.org/1140953003/diff/20001/ppapi/tests/test_case.cc#newcode20 ppapi/tests/test_case.cc:20: std::string StripPrefix(const std::string& test_name) { Can we remove this ...
5 years, 7 months ago (2015-05-14 01:53:47 UTC) #11
raymes
lgtm https://codereview.chromium.org/1140953003/diff/20001/ppapi/tests/test_case.cc File ppapi/tests/test_case.cc (right): https://codereview.chromium.org/1140953003/diff/20001/ppapi/tests/test_case.cc#newcode20 ppapi/tests/test_case.cc:20: std::string StripPrefix(const std::string& test_name) { On 2015/05/14 01:53:47, ...
5 years, 7 months ago (2015-05-14 01:55:01 UTC) #12
Paweł Hajdan Jr.
LGTM
5 years, 7 months ago (2015-05-14 10:05:50 UTC) #13
tommycli
https://codereview.chromium.org/1140953003/diff/20001/ppapi/tests/test_case.cc File ppapi/tests/test_case.cc (right): https://codereview.chromium.org/1140953003/diff/20001/ppapi/tests/test_case.cc#newcode20 ppapi/tests/test_case.cc:20: std::string StripPrefix(const std::string& test_name) { On 2015/05/14 01:55:01, raymes ...
5 years, 7 months ago (2015-05-14 17:44:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140953003/20001
5 years, 7 months ago (2015-05-14 17:44:55 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 17:54:09 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 17:54:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a88b609ba9a3df0f5cb9950a0564c9ee463f6f69
Cr-Commit-Position: refs/heads/master@{#329874}

Powered by Google App Engine
This is Rietveld 408576698