src/compiler/js-type-feedback.cc - Issue 1140943003: [turbofan] Reenable feedback for LoadNamed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-type-feedback.cc

Issue 1140943003: [turbofan] Reenable feedback for LoadNamed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-type-feedback.cc

diff --git a/src/compiler/js-type-feedback.cc b/src/compiler/js-type-feedback.cc

index 04861ea53227fbe0328254c22adc70edaef6335d..7cccfa721a0497f92c36b0164de22891bef1d49b 100644

--- a/src/compiler/js-type-feedback.cc

+++ b/src/compiler/js-type-feedback.cc

@@ -276,6 +276,7 @@ Reduction JSTypeFeedbackSpecializer::ReduceJSLoadProperty(Node* node) {

Reduction JSTypeFeedbackSpecializer::ReduceJSStoreNamed(Node* node) {

DCHECK(node->opcode() == IrOpcode::kJSStoreNamed);

+ if (true) return NoChange(); // TODO(titzer): storenamed is broken

Node* frame_state_before = GetFrameStateBefore(node);

if (frame_state_before == nullptr) return NoChange();

« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »